Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify searchbar to use vuetify toolbars (#17) #18

Closed
wants to merge 49 commits into from
Closed

feat: modify searchbar to use vuetify toolbars (#17) #18

wants to merge 49 commits into from

Conversation

gromdimon
Copy link
Contributor

@gromdimon gromdimon commented Aug 29, 2023 •
edited
Loading

Tasks:

  • Modify Search bar to use vyetify toolbar
  • Add Search Bar in HeaderDetailPage
  • Test

gromdimon added 30 commits August 15, 2023 12:28
@gromdimon
feat: environment files
ee5ab62
@gromdimon
feat: implement reverse_proxy
ca15639
@gromdimon
feat: tests for proxies
655cf0b
@gromdimon
fix: temporary fix for failing tests
2c1a2b4
@gromdimon
feat: first try to implement search bar
0b94d4c
@gromdimon
feat: search logic
8474734
@gromdimon
feat: new styling
49bca7e
@gromdimon
wip
7f3a086
@gromdimon
wip
41684f7
@gromdimon
wip
5fc52ba
@gromdimon
feat: environment files
0818705
@gromdimon
feat: implement reverse_proxy
56fd581
@gromdimon
feat: tests for proxies
81ab44d
@gromdimon
fix: temporary fix for failing tests
0909ef6
@gromdimon
feat: first try to implement search bar
fd79e52
@gromdimon
feat: search logic
a670963
@gromdimon
feat: new styling
bf56aa8
@gromdimon
wip
424b259
@gromdimon
wip
9dc6ca8
@gromdimon
pull
74d8450
@gromdimon
cleanup
ad9a08b
@gromdimon
cleanup#2
89c89b2
@gromdimon
feat: search logic + ui view
2a3a39c
@gromdimon
feat: geneInformation
967cc01
@gromdimon
wip
f95d69e
@gromdimon
wip
c7ec27a
@gromdimon
Delete info?hgnc-id=HGNC:1100
0e1a011
@gromdimon
wip
e7fcdde
@gromdimon
Merge branch '11-implement-gene-search-functionality-and-gene-informa…
2ced3e9 
…tion-page' of https://github.com/bihealth/reev into 11-implement-gene-search-functionality-and-gene-information-page
@gromdimon
wip
6254d7b
@gromdimon gromdimon linked an issue Aug 29, 2023 that may be closed by this pull request
Modify SearchBar to use Vuetify toolbars #17
Closed
@codecov
Copy link

codecov bot commented Aug 29, 2023 •
edited
Loading

Codecov Report

Patch coverage: 80.86% and project coverage change: -16.27% ⚠️

Comparison is base (c3884a4) 100.00% compared to head (39b9941) 83.73%.

Additional details and impacted files 
@@             Coverage Diff              @@
##              main      #18       +/-   ##
============================================
- Coverage   100.00%   83.73%   -16.27%     
============================================
  Files            3       14       +11     
  Lines           41      246      +205     
  Branches         0       49       +49     
============================================
+ Hits            41      206      +165     
- Misses           0       38       +38     
- Partials         0        2        +2
Flag Coverage Δ
backend 100.00% <100.00%> (ø)
frontend 80.67% <80.58%> (-19.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
frontend/src/router/index.ts 66.66% <50.00%> (ø)
frontend/src/views/HomeView.vue 60.00% <60.00%> (ø)
frontend/src/components/HeaderDetailPage.vue 71.42% <71.42%> (ø)
frontend/src/views/GeneDetailView.vue 76.28% <76.28%> (ø)
frontend/src/api/utils.ts 93.33% <93.33%> (ø)
frontend/src/stores/geneInfo.ts 96.66% <96.66%> (ø)
backend/app/main.py 100.00% <100.00%> (ø)
frontend/src/api/annonars.ts 100.00% <100.00%> (ø)
frontend/src/api/common.ts 100.00% <100.00%> (ø)
frontend/src/components/HeaderDefault.vue 100.00% <100.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gromdimon gromdimon marked this pull request as ready for review August 29, 2023 11:22
@gromdimon gromdimon changed the base branch from main to 11-implement-gene-search-functionality-and-gene-information-page August 30, 2023 07:43
Base automatically changed from 11-implement-gene-search-functionality-and-gene-information-page to main August 30, 2023 11:22
@gromdimon gromdimon changed the base branch from main to docker-search-variant August 30, 2023 12:08
@gromdimon gromdimon removed a link to an issue Aug 30, 2023
Modify SearchBar to use Vuetify toolbars #17
Closed
@gromdimon gromdimon closed this Aug 30, 2023
@gromdimon gromdimon deleted the 17-modify-searchbar-to-use-vuetify-toolbars branch August 30, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gromdimon